Add C# highlighting - #802
Merged
Merged
Conversation
clippy: fix ptr_as_ptr lint (microsoft#730)
Contributor
Author
|
@microsoft-github-policy-service agree |
|
There appears to be a clash with int/internal |
|
The letter 'T' is not handled correctly |
lhecker
enabled auto-merge (squash)
July 29, 2026 14:20
lhecker
disabled auto-merge
July 29, 2026 14:23
lhecker
approved these changes
Jul 29, 2026
Closed
Member
|
Thanks! |
Contributor
|
Nice, when is this expected to ship? And was the issue BrentKinny brought up above with |
Member
|
Not sure. I'll make a release based on my gut feeling, because getting permissions to release something is a real hassle. IIRC yes the issue was fixed. This regex engine implement left-most match first semantics so int|internal will match int because it comes first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds fairly comprehensive support for C# highlighting. I would like if someone checked if I have placed the keywords in the correct place as C# has quite of lot of them!
All test were passed when running
cargo test -qThis is my first time contributing to open source project, so feel free to scrutinise this contribution!